Fix: periodic loader rewrites best state

[ditwoo]

Before submitting

• Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
• Did you read the contribution guide?
• Did you check the code style? catalyst-make-codestyle && catalyst-check-codestyle (pip install -U catalyst-codestyle).
• Did you make sure to update the docs? We use Google format for all the methods and classes.
• Did you check the docs with make check-docs?
• Did you write any new necessary tests?
• Did you add your new functionality to the docs?
• Did you update the CHANGELOG?
• You can use 'Login as guest' to see Teamcity build logs.

Type of Change

• Examples / docs / tutorials / contributors update
• Bug fix (non-breaking change which fixes an issue)
• Improvement (non-breaking change which improves an existing feature)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

[pep8speaks]

Hello @ditwoo! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file tests/_tests_scripts/test_core_contrib_periodic_loader.py:

Line 47:80: E501 line too long (87 > 79 characters)

• In the file tests/_tests_scripts/test_core_runner_counters.py:

Line 28:80: E501 line too long (83 > 79 characters)

Comment last updated at 2020-07-03 06:31:31 UTC

[Scitator]

could you please add check=True flag for your tests?