Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Arc Margin Product #957

Merged
merged 10 commits into from Oct 10, 2020
Merged

Feature: Arc Margin Product #957

merged 10 commits into from Oct 10, 2020

Conversation

ditwoo
Copy link
Contributor

@ditwoo ditwoo commented Oct 8, 2020 •
edited

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contribution guide?
  • Did you check the code style? catalyst-make-codestyle && catalyst-check-codestyle (pip install -U catalyst-codestyle).
  • Did you make sure to update the docs? We use Google format for all the methods and classes.
  • Did you check the docs with make check-docs?
  • Did you write any new necessary tests?
  • Did you add your new functionality to the docs?
  • Did you update the CHANGELOG?
  • You can use 'Login as guest' to see Teamcity build logs.

Description

Related Issue

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Scitator
Scitator previously approved these changes Oct 9, 2020
View reviewed changes
bagxi
bagxi previously approved these changes Oct 9, 2020
View reviewed changes
catalyst/contrib/nn/modules/arcface.py Outdated Show resolved Hide resolved
@mergify mergify bot dismissed stale reviews from Scitator and bagxi October 9, 2020 13:55

Pull request has been modified.

bagxi
bagxi previously requested changes Oct 10, 2020
View reviewed changes
catalyst/contrib/nn/modules/softmax.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/arcmargin.py Outdated Show resolved Hide resolved
catalyst/contrib/nn/modules/cosface.py Outdated Show resolved Hide resolved
@mergify
Copy link

mergify bot commented Oct 10, 2020

This pull request is now in conflicts. @ditwoo, could you fix it? 🙏

@mergify mergify bot dismissed bagxi’s stale review October 10, 2020 10:40

Pull request has been modified.

bagxi
bagxi previously approved these changes Oct 10, 2020
View reviewed changes
@mergify mergify bot dismissed bagxi’s stale review October 10, 2020 11:42

Pull request has been modified.

@mergify mergify bot merged commit cc01e8a into catalyst-team:master Oct 10, 2020
@ditwoo ditwoo deleted the feature/arcmargin branch February 19, 2021 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scitator Scitator Scitator approved these changes

@bagxi bagxi bagxi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ditwoo @Scitator @bagxi