Recsys map #968
Merged
Recsys map #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scitator
previously requested changes
Oct 26, 2020
catalyst/metrics/avg_precision.py
Outdated
| Calculate the Average Precision (AP) for recsys | ||
| The precision metric summarizes the fraction of relevant items | ||
| out of the whole the recommendation list. | ||
| The average precision @ k (AP@k) metrics summarizes the average |
There was a problem hiding this comment.
maybe, this could help a bit https://stackoverflow.com/questions/45534757/how-to-use-inline-code-with-a-trailing-whitespace
catalyst/metrics/avg_precision.py
Outdated
|
|
||
|
|
||
| def avg_precision( | ||
| outputs: torch.Tensor, targets: torch.Tensor, k=100 |
| @@ -0,0 +1,64 @@ | |||
| import numpy as np | |||
There was a problem hiding this comment.
could we also add tests from recsys course?
| ) / float(index + 1) | ||
|
|
||
| ap = torch.mean(precisions, dim=1) | ||
| return ap |
There was a problem hiding this comment.
could we add docs, that we return Tensor with shape [bs]?
There was a problem hiding this comment.
and could we also add mean_avg_precision metric here?
mergify
bot
dismissed
Scitator’s stale review
Pull request has been modified.
added 2 commits
November 2, 2020 13:33
Scitator
previously approved these changes
Nov 2, 2020
added 2 commits
November 3, 2020 16:43
mergify
bot
dismissed
Scitator’s stale review
Pull request has been modified.
added 2 commits
November 3, 2020 17:41
Scitator
reviewed
Nov 3, 2020
catalyst/metrics/ndcg.py
Outdated
| import torch | ||
|
|
||
|
|
||
| def dcg( |
There was a problem hiding this comment.
extra spaces or dcg method?
Scitator
reviewed
Nov 3, 2020
catalyst/metrics/tests/test_ndcg.py
Outdated
|
|
||
| import numpy as np | ||
|
|
||
| import torch |
Scitator
previously approved these changes
Nov 3, 2020
added 2 commits
November 7, 2020 11:35
mergify
bot
dismissed
Scitator’s stale review
Pull request has been modified.
|
This pull request is now in conflicts. @zkid18, could you fix it? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
catalyst-make-codestyle && catalyst-check-codestyle(pip install -U catalyst-codestyle).make check-docs?pytest .?Description
Related Issue
Type of Change
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
PS