New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recsys functional #998
Recsys functional #998
Conversation
This reverts commit 9950d7d. Removed movielens by mistake
catalyst/metrics/functional.py
Outdated
@@ -81,6 +81,34 @@ def process_multiclass_components( | |||
return outputs, targets, num_classes | |||
|
|||
|
|||
def process_recsys( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
naming: process_recsys_components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
catalyst/metrics/ndcg.py
Outdated
@@ -28,55 +27,52 @@ def dcg( | |||
gain_function: | |||
String indicates the gain function for the ground truth labels. | |||
Two options available: | |||
- `pow_rank`: torch.pow(2, x) - 1 | |||
- `exp_rank`: torch.pow(2, x) - 1 | |||
- `rank`: x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linear_rank
?
Pull request has been modified.
Thank you for the PR, I will handle transformers test 🚀 |
Before submitting
catalyst-make-codestyle && catalyst-check-codestyle
(pip install -U catalyst-codestyle
).make check-docs
?pytest .
?Description
Related Issue
Type of Change
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
PS