Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option for any existing attribute maps #139

Closed
3 tasks
brendanheywood opened this issue Sep 19, 2017 · 1 comment
Closed
3 tasks

Add config option for any existing attribute maps #139

brendanheywood opened this issue Sep 19, 2017 · 1 comment

Comments

@brendanheywood
Copy link
Contributor

brendanheywood commented Sep 19, 2017

What happened?

A common issue, especially with ADFS, is that the attributes are returned using large name spaced strings, ie instead of 'uid' as the key you will get:

http://schemas.xmlsoap.org/ws/2005/05/identity/claims/nameidentifier

In theory this should still work, but it's a little awkward and makes for a lot of support queries. There are several workarounds and potential fixes:

https://github.com/catalyst/moodle-auth_saml2/blob/MOODLE_33PLUS/config/config.php#L82-L83

A workaround many people have done with ADFS is to configure a custom claim which just uses the short human readable key name instead of the long xmlsoap one. See an example of these custom claims here: #124 (comment)

@brendanheywood brendanheywood changed the title Support any attribute maps Add config option for any existing attribute maps Nov 22, 2018
@brendanheywood
Copy link
Contributor Author

I've implemented this, but in a more flexible way. I was originally intending to use the SSP attribute map proc, but after some testing it doesn't work in reverse unless you have an explicit reverse mapping file, eg

https://github.com/catalyst/moodle-auth_saml2/blob/master/extlib/simplesamlphp/attributemap/urn2oid.php
vs
https://github.com/catalyst/moodle-auth_saml2/blob/master/extlib/simplesamlphp/attributemap/oid2urn.php

But there is not a claim2name reverse mapping for ADFS in SSP. I thought about adding it, but instead I've made a much more flexible and robust attribute simplification setting which should work with just about any odd shaped data that gets thrown at it and from any scheme or namespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant