#29 - 401 - prevent warnings on empty email addresses #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the workflow fails regarding code checker, but for issues not related to the changes added with this PR. |
|
Thanks for allowing this CI to run. I can see the same errors here than in my repo's CI. Regarding the moodle code check, If you want, I can add a second commit in this PR to make it pass properly, without errors. Let me know. Thanks |
|
can't see any issues with merging this in - especially if it means you don't have to maintain local changes to it on your end too - thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the patch presented on #29, ready to be considered and included if necessary.
Thanks a lot.