Issue #93: Add support for customfield backup/restore #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypha
force-pushed
the
93-backup-restore
branch
2 times, most recently
from
63850ba
to
0e78958
Compare
marcusboon
reviewed
Dec 14, 2023
| * | ||
| * @param int $instanceid id of the instance or 0 if the instance is being created | ||
| * @return \context | ||
| */ | ||
| public function get_instance_context(int $instanceid = 0): \context { | ||
| return $this->get_configuration_context(); | ||
| $modinfo = get_coursemodule_from_instance('cms', $instanceid); |
There was a problem hiding this comment.
What happens here if $instanceid = 0 does it fail/explode? Or is the understanding that $instanceid can never be 0?
There was a problem hiding this comment.
I put in a extra check, just in case.
jaypha
force-pushed
the
93-backup-restore
branch
from
0e78958
to
721c41b
Compare
|
Just a reminder this needs another look. Cheers. |
jaypha
force-pushed
the
93-backup-restore
branch
from
721c41b
to
807bc31
Compare
|
I just did a check and everything still works. OK to have reviewed and merged. |
|
Hi @jaypha any further updates on this? Would you like me to review? Cheers. |
jaypha
force-pushed
the
93-backup-restore
branch
2 times, most recently
from
0ea4aeb
to
4cc8e25
Compare
jaypha
force-pushed
the
93-backup-restore
branch
from
4cc8e25
to
92177ad
Compare
Yeah. Sure. It is ready now. Unit tests have been implemented for fields and userlist, which use custom fields. |
Fragonite
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #93