Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernise the way proxy connections work #88

Open
brendanheywood opened this issue Dec 1, 2022 · 1 comment
Open

Modernise the way proxy connections work #88

brendanheywood opened this issue Dec 1, 2022 · 1 comment

Comments

@brendanheywood
Copy link
Contributor

This will redo the work done in this issue:

#9

and do it so that all the proxy logic is handled centrally in local_aws instead

https://github.com/catalyst/moodle-local_aws/blob/master/classes/local/client_factory.php#L44-L60

@Peterburnett
Copy link
Contributor

The strategy here will be to add a middleware to the guzzle stack, which configures the proxy settings for the request, based on the URL of the request, as in the above function.

The main function is currently protected, and the best strategy here will likely be to copy the Awsclient implementation to a new function that accepts a GuzzleClient, and from there, configures the middleware into the callstack in the same way. The same middleware function should work but might need some tweaking

andrewmadden added a commit that referenced this issue Jan 24, 2023
  * Also fixes unit tests to be consistent if test server sets proxy in
    config.php.
andrewmadden added a commit that referenced this issue Jan 24, 2023
  * Also fixes unit tests to be consistent if test server sets proxy in
    config.php.
andrewmadden added a commit that referenced this issue Jan 24, 2023
  * Also fixes unit tests to be consistent if test server sets proxy in
    config.php.
andrewmadden added a commit that referenced this issue Jan 27, 2023
  * Also fixes unit tests to be consistent if test server sets proxy in
    config.php.
andrewmadden added a commit that referenced this issue Jan 27, 2023
  * Also fixes unit tests to be consistent if test server sets proxy in
    config.php.
keevan added a commit that referenced this issue Feb 6, 2023
…cal_aws_proxy_builders

Issue #88 Use local_aws middleware to manage requests with proxies
matthewhilton pushed a commit that referenced this issue Sep 8, 2023
  * Also fixes unit tests to be consistent if test server sets proxy in
    config.php.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants