Added property check on Tika responses #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occasionally, Apache Tika responses may not include an `X-TIKA:content` property, causing the following error to be thrown: `PHP Warning: Undefined property: stdClass::$X-TIKA:content` on line 159 in `search/engine/elastic/classes/enrich/text/tika.php`. Signed-off-by: Lars Thoms <lars@thoms.io>
|
Hi @SpaceCafe ! Thanks for providing a patch. Can you please create an issue first describing the error that you are having. That can help people with the same issue see that it has been fixed. Also why does Tika responses not include an X-TIKA:content property? What does this mean from tika point of view? Should we treat it as an error and throw an exception? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally, Apache Tika responses may not include an
X-TIKA:contentproperty, causing the following error to be thrown:PHP Warning: Undefined property: stdClass::$X-TIKA:contenton line 159 insearch/engine/elastic/classes/enrich/text/tika.php.