Remove unnecessary dynamic properties #174

catalyst · Jun 21, 2024 · 31b8bcf · 31b8bcf
1 parent e7bf0c2
commit 31b8bcf
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 11 deletions.
diff --git a/classes/check/collectorcheck.php b/classes/check/collectorcheck.php
@@ -31,14 +31,6 @@
  */
 class collectorcheck extends check {
 
-    /**
-     * Constructor
-     */
-    public function __construct() {
-        $this->id = 'checkcollectorcheck';
-        $this->name = get_string('checkcollectorcheck', 'tool_cloudmetrics');
-    }
-
     /**
      * A link to a place to action this
      *

diff --git a/classes/check/metriccheck.php b/classes/check/metriccheck.php
@@ -42,8 +42,6 @@ class metriccheck extends check {
      */
     public function __construct($metric) {
         $this->metric = $metric;
-        $this->id = $metric->get_name();
-        $this->name = $metric->get_label();
     }
 
     /**
@@ -52,7 +50,7 @@ public function __construct($metric) {
      * @return string must be unique within a component
      */
     public function get_id(): string {
-        return $this->id;
+        return $this->metric->get_name();
     }
 
     /**