-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style: snake_case vs camelCase #3
Comments
Where exactly would you like camel case? On Thursday, September 10, 2015, Johannes Lumpe notifications@github.com
|
Basically on every part which is exposed to the public, meaning all public api methods. I know that this would be a breaking change though (or at least one which would require the deprecation of the previous methods - although there could just be aliases for now) |
Well, the only public API name that comes to my mind is |
There would be |
ok, i'll think about it this evening. |
Ah sure. I'm talking about the config options available here: https://github.com/halt-hammerzeit/webpack-isomorphic-tools#configuration |
done. i didn't check it but it should work now. |
Hey @halt-hammerzeit, first of all great work on this library - it's such a better solution to this problem than some of the other methods out there. Are you still open to a PR to create camelCase aliases for the API and to update the docs? If you are, I'll submit a PR when I have a spare moment. Personally, I would just move all of it to camelCase - it's not a major problem but it's a little jarring since it's such a contrast to every other library out there. |
Yeah, I'm open to a PR camel casing the public API. |
FYI |
@halt-hammerzeit I like the look of your new library since it's more in tune with how webpack recommend doing this, but tbh I'm not totally sold on webpack's approach in general. It feels a bit odd to have to transpile the backend, it seems like it will be hard to debug if something goes wrong and at a base level it seems a little weird to have to go through a build process for a duck-typed/dynamic language since you're not really getting any benefit from it. Now that you've done both approaches, which do you think you prefer? |
@sampeka I don't like the transpiling approach either. Especially for the server, because you absolutely can do it on-the-fly. Debugging isn't more difficult since source maps are working. I would prefer the newer library for new projects, still I'm not migrating my own projects because I don't use any Webpack plugins and features since I like pure javascript more and I'm not sold on all this Webpackish stuff: it brings complexity to my favourite Node.js, magic and stuff. Webpack is a neccessary piece of technology but I believe in more simple stuff. |
What do you think - would you be open to move to camelCase, as it is somewhat the community standard for JS?
The text was updated successfully, but these errors were encountered: