Skip to content
This repository has been archived by the owner on Dec 3, 2019. It is now read-only.

Commit

Permalink
[Telemetry] Add temporary logging to desktop_browser_finder
Browse files Browse the repository at this point in the history
We've seen scenarios where DesktopBrowserFinder unit tests fail because
sys.platform reports a wrong platform, presumably due to being stubbed out too
aggressively by system_stub. This CL adds some temporary logging to make sure
that the reason browsers sometimes can't be found on the Catapult CQ is due to
this stubbing problem.

BUG=catapult:#3074
NOTRY=true

Review-Url: https://codereview.chromium.org/2567783002
  • Loading branch information
eakuefner authored and Commit bot committed Dec 9, 2016
1 parent df23635 commit 707aaac
Showing 1 changed file with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,8 @@ def FindAllBrowserTypes(_):

def FindAllAvailableBrowsers(finder_options, device):
"""Finds all the desktop browsers available on this machine."""
logging.warning('sys.platform reports %s to DesktopBrowserFinder',
sys.platform)
if not isinstance(device, desktop_device.DesktopDevice):
return []

Expand Down

0 comments on commit 707aaac

Please sign in to comment.