Skip to content
This repository has been archived by the owner on Dec 3, 2019. It is now read-only.

Migrate tracing/ and dashboard/ to Polymer 1.0 #2285

Closed
zeptonaut opened this issue Apr 26, 2016 · 1 comment
Closed

Migrate tracing/ and dashboard/ to Polymer 1.0 #2285

zeptonaut opened this issue Apr 26, 2016 · 1 comment

Comments

@zeptonaut
Copy link
Contributor

No description provided.

chromium-infra-bot pushed a commit that referenced this issue Apr 26, 2016
chromium-infra-bot pushed a commit that referenced this issue Apr 27, 2016
TBR=aiolos@chromium.org
NOTRY=true
NOPRESUBMIT=true
BUG=catapult:#2285

Review-Url: https://codereview.chromium.org/1923953003
chromium-infra-bot pushed a commit that referenced this issue Apr 27, 2016
BUG=catapult:#2285
R=eakuefner@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/1930563002
chromium-infra-bot pushed a commit that referenced this issue Apr 27, 2016
BUG=catapult:#2285
R=eakuefner@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/1924873002
chromium-infra-bot pushed a commit that referenced this issue Apr 27, 2016
Polymer 1.0 makes this near impossible to do and using normal JS
handlers should do the trick.

NOTRY=true
NOPRESUBMIT=true
BUG=catapult:#2285

Review-Url: https://codereview.chromium.org/1931603002
chromium-infra-bot pushed a commit that referenced this issue Apr 27, 2016
TBR=aiolos@chromium.org
NOTRY=true
NOPRESUBMIT=true
BUG=catapult:#2285

Review-Url: https://codereview.chromium.org/1929693002
chromium-infra-bot pushed a commit that referenced this issue Apr 28, 2016
BUG=catapult:#2285
R=eakuefner@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/1926883002
eakuefner added a commit that referenced this issue Apr 28, 2016
HTMLUnknownElement is a really crazy thing to extend, so this changes
base_chart to extend HTMLDivElement and fixes 34 unit tests in the process.

BUG=catapult:#2285
R=aiolos@chromium.org

Review URL: https://codereview.chromium.org/1926103002 .
eakuefner added a commit that referenced this issue Apr 28, 2016
BUG=catapult:#2285
R=sullivan@chromium.org, dtu@chromium.org

Review URL: https://codereview.chromium.org/1929673003 .
chromium-infra-bot pushed a commit that referenced this issue Apr 28, 2016
HTMLTestRunner extends HTMLUnknownElement, which we think is dangerous.
Extending HTMLDivElement instead doesn't make any more tests pass, but that's
probably just because it isn't unit tested.

It doesn't cause anything to break.

BUG=catapult:#2285
NOPRESUBMIT=true
NOTRY=true

Review-Url: https://codereview.chromium.org/1925833003
chromium-infra-bot pushed a commit that referenced this issue Apr 28, 2016
Again, this doesn't cause any more tests to pass, but also doesn't break
anything.

BUG=catapult:#2285
NOTRY=true
NOPRESUBMIT=true
TBR=charliea@chromium.org

Review-Url: https://codereview.chromium.org/1925833004
chromium-infra-bot pushed a commit that referenced this issue Apr 28, 2016
No additional tests pass, but no tests break.

BUG=catapult:#2285
TBR=charlie@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/1929053002
chromium-infra-bot pushed a commit that referenced this issue Apr 28, 2016
No additional tests pass.

BUG=catapult:#2285
TBR=charliea@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/1925183002
chromium-infra-bot pushed a commit that referenced this issue Apr 28, 2016
TBR=eakuefner@chromium.org,aiolos@chromium.org
NOTRY=true
NOPRESUBMIT=true
BUG=catapult:#2285

Review-Url: https://codereview.chromium.org/1925993003
chromium-infra-bot pushed a commit that referenced this issue Apr 28, 2016
BUG=catapult:#2285
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/1922863004
chromium-infra-bot pushed a commit that referenced this issue Apr 28, 2016
chromium-infra-bot pushed a commit that referenced this issue Apr 28, 2016
chromium-infra-bot pushed a commit that referenced this issue Apr 28, 2016
chromium-infra-bot pushed a commit that referenced this issue Apr 28, 2016
BUG=catapult:#2285
R=dtu@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/1923973003
chromium-infra-bot pushed a commit that referenced this issue Apr 28, 2016
BUG=catapult:#2285
R=dtu@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/1929563002
chromium-infra-bot pushed a commit that referenced this issue Apr 28, 2016
BUG=catapult:#2285
R=dtu@chromium.org,sullivan@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/1929973002
chromium-infra-bot pushed a commit that referenced this issue Apr 28, 2016
chromium-infra-bot pushed a commit that referenced this issue May 4, 2016
chromium-infra-bot pushed a commit that referenced this issue May 5, 2016
…lymer 1.0

These are the last three dashboard files.

BUG=catapult:#2285
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/1955433004
chromium-infra-bot pushed a commit that referenced this issue May 5, 2016
TBR=aiolos@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG=catapult:#2285

Review-Url: https://codereview.chromium.org/1957493002
zeptonaut pushed a commit that referenced this issue Jul 21, 2016
TBR=sullivan@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG=catapult:#2285

Review-Url: https://codereview.chromium.org/2158403004
zeptonaut pushed a commit that referenced this issue Jul 21, 2016
Polymer.dom'ing is only necessary/possible before setAttribute

TBR=sullivan@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG=catapult:#2285

Review-Url: https://codereview.chromium.org/2159353002
zeptonaut pushed a commit that referenced this issue Jul 21, 2016
In the last merge, we lifted the restriction that prevented us from
adding non-analysis views as sub views of the tab view. We did this in
order to stay compatible with recent results2.html code that had been
written.

TBR=sullivan@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG=catapult:#2285

Review-Url: https://codereview.chromium.org/2158303003
zeptonaut pushed a commit that referenced this issue Jul 21, 2016
The code here is pulled directly from master.

TBR=sullivan@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG=catapult:#2285

Review-Url: https://codereview.chromium.org/2160983005
zeptonaut pushed a commit that referenced this issue Jul 21, 2016
TBR=sullivan@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG=catapult:#2285

Review-Url: https://codereview.chromium.org/2163833002
chromium-infra-bot pushed a commit that referenced this issue Jul 21, 2016
TBR=sullivan@chromium.org,aiolos@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG=catapult:#2285

Review-Url: https://codereview.chromium.org/2169083002
chromium-infra-bot pushed a commit that referenced this issue Jul 21, 2016
TBR=sullivan@chromium.org,aiolos@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG=catapult:#2285

Review-Url: https://codereview.chromium.org/2168763004
chromium-infra-bot pushed a commit that referenced this issue Jul 21, 2016
TBR=sullivan@chromium.org,charliea@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG=catapult:#2285

Review-Url: https://codereview.chromium.org/2166993003
chromium-infra-bot pushed a commit that referenced this issue Jul 21, 2016
TBR=sullivan@chromium.org,aiolos@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG=catapult:#2285

Review-Url: https://codereview.chromium.org/2168933003
chromium-infra-bot pushed a commit that referenced this issue Jul 21, 2016
TBR=sullivan@chromium.org,aiolos@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG=catapult:#2285

Review-Url: https://codereview.chromium.org/2169093002
chromium-infra-bot pushed a commit that referenced this issue Jul 21, 2016
TBR=sullivan@chromium.org,aiolos@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG=catapult:#2285

Review-Url: https://codereview.chromium.org/2168193003
chromium-infra-bot pushed a commit that referenced this issue Jul 21, 2016
TBR=sullivan@chromium.org,aiolos@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG=catapult:#2285

Review-Url: https://codereview.chromium.org/2167933004
eakuefner added a commit that referenced this issue Jul 21, 2016
BUG=catapult:#2285
NOTRY=true
NOPRESUBMIT=true
R=aiolos@chromium.org

Review URL: https://codereview.chromium.org/2164413002 .
Apeliotes added a commit that referenced this issue Jul 21, 2016
TBR=sullivan@chromium.org,charliea@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG=catapult:#2285

Review URL: https://codereview.chromium.org/2170083002 .
zeptonaut pushed a commit that referenced this issue Jul 21, 2016
Unfortunately, this fixes unselected test display in report-page-test but
not production.

BUG=catapult:#2285
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2170613002
zeptonaut pushed a commit that referenced this issue Jul 21, 2016
TBR=sullivan@chromium.org,aiolos@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG=catapult:#2285

Review URL: https://codereview.chromium.org/2165023006 .
zeptonaut pushed a commit that referenced this issue Jul 21, 2016
TBR=sullivan@chromium.org,aiolos@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG=catapult:#2285

Review URL: https://codereview.chromium.org/2171013002 .
zeptonaut pushed a commit that referenced this issue Jul 21, 2016
(This was accidentally deleted in a rebase.)

TBR=sullivan@chromium.org,aiolos@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG=catapult:#2285

Review URL: https://codereview.chromium.org/2175443002 .
Apeliotes added a commit that referenced this issue Jul 21, 2016
zeptonaut pushed a commit that referenced this issue Jul 21, 2016
TBR=sullivan@chromium.org,aiolos@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG=catapult:#2285

Review URL: https://codereview.chromium.org/2172783002 .
zeptonaut pushed a commit that referenced this issue Jul 21, 2016
TBR=sullivan@chromium.org,aiolos@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG=catapult:#2285

Review URL: https://codereview.chromium.org/2163983007 .
zeptonaut pushed a commit that referenced this issue Jul 21, 2016
TBR=sullivan@chromium.org,aiolos@chromium.org
NOPRESUBMIT=true
NOTRY=true
BUG=catapult:#2285

Review URL: https://codereview.chromium.org/2168243002 .
zeptonaut pushed a commit that referenced this issue Jul 21, 2016
Revert "Temporarily close catapult tree until polymer 1.0 migration is complete."

This reverts commit c66d67b.

NOPRESUBMIT=true
NOTRY=true
BUG=catapult:#2285
R=sullivan@chromium.org

Review URL: https://codereview.chromium.org/2170133002 .
@zeptonaut
Copy link
Contributor Author

And as he clicked the "Close and comment" link, a chorus of angels were said to have struck a beautiful note from on high...

beyondgfw pushed a commit to googlehosts/catapult that referenced this issue Jan 21, 2019
BUG=catapult:catapult-project#2285
NOTRY=true
NOPRESUBMIT=true
R=aiolos@chromium.org

Review-Url: https://codereview.chromium.org/2113853002
beyondgfw pushed a commit to googlehosts/catapult that referenced this issue Jan 21, 2019
This merge contains all Catapult changes until 10:30am on 7/19/16.

There are still 5 trace viewer tests failing, but I'll fix those up in
later CLs.

Files with major work include:

  - tracing/tracing/value/ui/value_set_table.html
  - tracing/tracing/value/ui/value_set_view[_test].html
  - tracing/tracing/ui/base/table[_test].html

NOPRESUBMIT=true
NOTRY=true
BUG=catapult:catapult-project#2285
R=sullivan@chromium.org

Review URL: https://codereview.chromium.org/2162963002 .
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants