Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential SEGV in TZeroCopyEvaluator::SetModelPtr #1809

Closed
kazeevn opened this issue Aug 16, 2021 · 1 comment
Closed

Potential SEGV in TZeroCopyEvaluator::SetModelPtr #1809

kazeevn opened this issue Aug 16, 2021 · 1 comment

Comments

@kazeevn
Copy link
Contributor

kazeevn commented Aug 16, 2021

Perhaps it is better to first check whether ObliviousTrees == nullptr before dereferencing it, i.e. if the conditional on line 77 is ever true, it will never be reached, as there will be a SEGV on line 75.

Credit to Gerhard Raven@CERN
@kizill
Copy link
Member

kizill commented Aug 17, 2021

Fixed in master, thank you for noticing a bug :)

robot-piglet pushed a commit that referenced this issue Jan 16, 2023
@kizill
Fix potential sigsegv in evaluator. Fixes #1809
3708e4c 
ref:5295eaf54818927746493090f8d5902d145ee1d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kizill @kazeevn