Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the title #2234

Closed
wants to merge 1 commit into from
Closed

Added the title #2234

wants to merge 1 commit into from

Conversation

elenaspb2019
Copy link
Contributor

@elenaspb2019 elenaspb2019 commented Nov 22, 2022 •
edited
Loading

Added the title, fixed the order

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Before submitting a pull request, please do the following steps:

  1. Read instructions for contributors.
  2. Run ya make in catboost folder to make sure the code builds.
  3. Add tests that test your change.
  4. Run tests using ya make -t -A command.
  5. If you haven't already, complete the CLA.

@elenaspb2019
Added the title
4361502 
Added the title, fixed the order
@Evgueni-Petrov-aka-espetrov
Copy link
Contributor

hi @elenaspb2019 !!!
glad to see you here 🤝
and thank you so much for this PR 🌹 🌹 🌹
could you please sign the Yandex CLA https://catboost.ai/en/docs/concepts/development-and-contributions#yandex-cla ?
this is formally needed to merge your PR...

@elenaspb2019
Copy link
Contributor Author

hi @elenaspb2019 !!! glad to see you here handshake and thank you so much for this PR rose rose rose could you please sign the Yandex CLA https://catboost.ai/en/docs/concepts/development-and-contributions#yandex-cla ? this is formally needed to merge your PR...

Hello Evgueni! Sure, I did it above. Thank you for reminding :)

@Evgueni-Petrov-aka-espetrov
Copy link
Contributor

@elenaspb2019
according to CONTRIBUTING.md we need a formal statement from you as follows

image

@elenaspb2019
Copy link
Contributor Author

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

@Evgueni-Petrov-aka-espetrov
Copy link
Contributor

@arcadia-devtools Ship it!

@arcadia-devtools
Copy link
Collaborator

CLA already signed

@arcadia-devtools
Copy link
Collaborator

@Evgueni-Petrov-aka-espetrov, internal review request created: 3187704

robot-piglet pushed a commit to catboost/docs that referenced this pull request Nov 24, 2022
Pull request "Added the title" by @elenaspb2019 from catboost/catboos…
57048e2 
…t#2234

MERGED FROM catboost/catboost#2234
arcadia-devtools added a commit that referenced this pull request Dec 4, 2022
@arcadia-devtools
Pull request "Added the title" by @elenaspb2019 from #2234
5f846f0 
MERGED FROM #2234

ref:771a39be9b6ec312727d508420ef43cbef17f6ea
robot-piglet pushed a commit that referenced this pull request Dec 27, 2022
@arcadia-devtools
Pull request "Added the title" by @elenaspb2019 from #2234
f069869 
MERGED FROM #2234

ref:c6567f08f84f3aa97cc80c153bfa7dd81eb3c25a
robot-piglet pushed a commit that referenced this pull request Jan 5, 2023
@arcadia-devtools
Pull request "Added the title" by @elenaspb2019 from #2234
35e2b02 
MERGED FROM #2234

ref:9fa5139e400b405f15a0d9ff1c1825f1089cfb44
robot-piglet pushed a commit that referenced this pull request Jan 17, 2023
@arcadia-devtools
Pull request "Added the title" by @elenaspb2019 from #2234
5a99430 
MERGED FROM #2234

ref:771a39be9b6ec312727d508420ef43cbef17f6ea
robot-piglet pushed a commit that referenced this pull request Jan 17, 2023
@arcadia-devtools
Pull request "Added the title" by @elenaspb2019 from #2234
0589dc9 
MERGED FROM #2234

ref:c6567f08f84f3aa97cc80c153bfa7dd81eb3c25a
robot-piglet pushed a commit that referenced this pull request Jan 17, 2023
@arcadia-devtools
Pull request "Added the title" by @elenaspb2019 from #2234
82d7fde 
MERGED FROM #2234

ref:9fa5139e400b405f15a0d9ff1c1825f1089cfb44
@andrey-khropov
Copy link
Member

Auto closing of merged PRs has been broken, so I have to close it manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evgueni-Petrov-aka-espetrov Evgueni-Petrov-aka-espetrov Evgueni-Petrov-aka-espetrov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elenaspb2019 @Evgueni-Petrov-aka-espetrov @arcadia-devtools @andrey-khropov