Some structure fixes and improvements #2235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some structure fixes and improvements
Evgueni-Petrov-aka-espetrov
requested changes
Nov 25, 2022
Comment on lines
61
to
62
| loss_function = "CrossEntropy", | ||
| train_dir = "crossentropy") |
There was a problem hiding this comment.
please add indentation (4 spaces)
There was a problem hiding this comment.
please add indentation (4 spaces)
Added
Comment on lines
55
to
56
| ["a", "b", 4, 5, 6, 7], | ||
| ["c", "d", 30, 40, 50, 60]] |
There was a problem hiding this comment.
please add indentation (4 spaces)
There was a problem hiding this comment.
please add indentation (4 spaces)
Added
Comment on lines
104
to
105
| ["a", "b", 4, 5, 6, 7], | ||
| ["c", "d", 30, 40, 50, 60]] |
There was a problem hiding this comment.
please add indentation (4 spaces)
There was a problem hiding this comment.
please add indentation (4 spaces)
Added
Minor fixes
Evgueni-Petrov-aka-espetrov
approved these changes
Nov 25, 2022
|
@arcadia-devtools Ship it! |
|
CLA already signed |
|
@Evgueni-Petrov-aka-espetrov, internal review request created: 3196291 |
Removed space
Evgueni-Petrov-aka-espetrov
approved these changes
Nov 28, 2022
|
@arcadia-devtools Ship it! |
|
@Evgueni-Petrov-aka-espetrov, internal review request updated: 3196291 |
robot-piglet
pushed a commit
to catboost/docs
that referenced
this pull request
Nov 28, 2022
|
Auto closing of merged PRs has been broken, so I have to close it manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some structure fixes and improvements
Before submitting a pull request, please do the following steps:
ya makein catboost folder to make sure the code builds.ya make -t -Acommand.I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en.