Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache TBB local executors #2203

Merged
merged 6 commits into from Dec 15, 2022
Merged

Cache TBB local executors #2203

merged 6 commits into from Dec 15, 2022

Conversation

NEvOlll
Copy link
Contributor

@NEvOlll NEvOlll commented Oct 26, 2022

Before submitting a pull request, please do the following steps:

  1. Read instructions for contributors.
  2. Run ya make in catboost folder to make sure the code builds.
  3. Add tests that test your change.
  4. Run tests using ya make -t -A command.
  5. If you haven't already, complete the CLA.

@NEvOlll NEvOlll changed the title TTtbb local executor cache Cache TBB local executors Oct 27, 2022
@kizill
Copy link
Member

kizill commented Oct 30, 2022

@arcadia-devtools Ship it!

kizill
kizill requested changes Oct 30, 2022
View reviewed changes
Copy link
Member

@kizill kizill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can I also ask you to use TBB caching in other places where we create thread pool inside _catboost.pyx ?

@arcadia-devtools
Copy link
Collaborator

@NEvOlll, please agree to the CLA (https://github.com/catboost/catboost/blob/master/CONTRIBUTING.md#provide-contributions)

@arcadia-devtools
Copy link
Collaborator

@kizill, internal review request created: 3104648

@NEvOlll
Copy link
Contributor Author

NEvOlll commented Oct 31, 2022

LGTM! Can I also ask you to use TBB caching in other places where we create thread pool inside _catboost.pyx ?

Yes, I have fixed it.

@kizill
Copy link
Member

kizill commented Nov 7, 2022

@arcadia-devtools Ship it!

@arcadia-devtools
Copy link
Collaborator

@kizill, internal review request updated: 3104648

arcadia-devtools added a commit that referenced this pull request Nov 12, 2022
@arcadia-devtools
Pull request "Cache TBB local executors" by @NEvOlll from #2203
6b68286 
MERGED FROM #2203

ref:9241b12a315d762c324dd1bc47c968057fbf91b8
arcadia-devtools added a commit that referenced this pull request Nov 22, 2022
@arcadia-devtools
Pull request "Cache TBB local executors" by @NEvOlll from #2203
8cbadc4 
MERGED FROM #2203

ref:caae2e0d031d197a096970e90386b6cdcb19f7f8
arcadia-devtools added a commit that referenced this pull request Nov 30, 2022
@arcadia-devtools
Pull request "Cache TBB local executors" by @NEvOlll from #2203
4fefe68 
MERGED FROM #2203

ref:69ec29021a7f7a806871f65ddb1f1d15063cc3e6
arcadia-devtools added a commit that referenced this pull request Dec 3, 2022
@arcadia-devtools
Pull request "Cache TBB local executors" by @NEvOlll from #2203
de9d827 
MERGED FROM #2203

ref:0e10a828202d2b005c6436c76e3f76e1964e43fe
@kizill kizill merged commit c6f9f45 into catboost:master Dec 15, 2022
robot-piglet pushed a commit that referenced this pull request Dec 26, 2022
@arcadia-devtools
Pull request "Cache TBB local executors" by @NEvOlll from #2203
8f351a7 
MERGED FROM #2203

ref:0e3e01a8e3e1c02ccb80886772a0b13623e707c4
robot-piglet pushed a commit that referenced this pull request Jan 2, 2023
@arcadia-devtools
Pull request "Cache TBB local executors" by @NEvOlll from #2203
c4b4327 
MERGED FROM #2203

ref:99bd829f06081638999c9f6945ff4827a85a307e
robot-piglet pushed a commit that referenced this pull request Jan 4, 2023
@arcadia-devtools
Pull request "Cache TBB local executors" by @NEvOlll from #2203
c85b00f 
MERGED FROM #2203

ref:538ad1cf61ce4bb6f85ece2ddf22467f274241b3
robot-piglet pushed a commit that referenced this pull request Jan 17, 2023
@arcadia-devtools
Pull request "Cache TBB local executors" by @NEvOlll from #2203
d62c416 
MERGED FROM #2203

ref:9241b12a315d762c324dd1bc47c968057fbf91b8
robot-piglet pushed a commit that referenced this pull request Jan 17, 2023
@arcadia-devtools
Pull request "Cache TBB local executors" by @NEvOlll from #2203
63f55ce 
MERGED FROM #2203

ref:caae2e0d031d197a096970e90386b6cdcb19f7f8
robot-piglet pushed a commit that referenced this pull request Jan 17, 2023
@arcadia-devtools
Pull request "Cache TBB local executors" by @NEvOlll from #2203
5cc203f 
MERGED FROM #2203

ref:69ec29021a7f7a806871f65ddb1f1d15063cc3e6
robot-piglet pushed a commit that referenced this pull request Jan 17, 2023
@arcadia-devtools
Pull request "Cache TBB local executors" by @NEvOlll from #2203
2166793 
MERGED FROM #2203

ref:0e10a828202d2b005c6436c76e3f76e1964e43fe
robot-piglet pushed a commit that referenced this pull request Jan 17, 2023
@arcadia-devtools
Pull request "Cache TBB local executors" by @NEvOlll from #2203
3aec364 
MERGED FROM #2203

ref:0e3e01a8e3e1c02ccb80886772a0b13623e707c4
robot-piglet pushed a commit that referenced this pull request Jan 17, 2023
@arcadia-devtools
Pull request "Cache TBB local executors" by @NEvOlll from #2203
7d410c4 
MERGED FROM #2203

ref:99bd829f06081638999c9f6945ff4827a85a307e
robot-piglet pushed a commit that referenced this pull request Jan 17, 2023
@arcadia-devtools
Pull request "Cache TBB local executors" by @NEvOlll from #2203
a0c9709 
MERGED FROM #2203

ref:538ad1cf61ce4bb6f85ece2ddf22467f274241b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kizill kizill kizill approved these changes

@Evgueni-Petrov-aka-espetrov Evgueni-Petrov-aka-espetrov Awaiting requested review from Evgueni-Petrov-aka-espetrov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NEvOlll @kizill @arcadia-devtools @Evgueni-Petrov-aka-espetrov