gcc warns for comparison of unsigned long long

[colonelsammy]

Comparison of unsigned long long to 'Y' doesn't warn for assert but does warn for REQUIRE:

    unsigned long long v = 0;
    assert(v == 0); // doesn't warn
    REQUIRE(v == 0); // warning - comparison between unsigned long long and int

catch_evaluate needs some more overloads for 'unsigned X to Y' and 'Y to unsigned X' (where 'X' is unsigned long long), e.g:

    // unsigned X to int
    template<Operator Op> bool compare( unsigned long long lhs, int rhs )
    {
        return applyEvaluator<Op>( lhs, static_cast<unsigned long long>( rhs ) );
    }
    ...
    // unsigned X to long
    template<Operator Op> bool compare( unsigned long long lhs, long rhs )
    {
        return applyEvaluator<Op>( lhs, static_cast<unsigned long long>( rhs ) );
    }
    ...
    // int to unsigned X
    template<Operator Op> bool compare( int lhs, unsigned long long rhs )
    {
        return applyEvaluator<Op>( static_cast<unsigned long long>( lhs ), rhs );
    }
    ...
    // long to unsigned X
    template<Operator Op> bool compare( long lhs, unsigned long long rhs )
    {
        return applyEvaluator<Op>( static_cast<unsigned long long>( lhs ) );
    }

Note: No warnings issued on Windows even with W4.

[philsquared]

Hmm... will see if I can add these in a portable way

[philsquared]

Better late than never. I've added this now (v1.2.1-develop.9)

[krvajal]

It seems that this was fixed a long time ago. I will close this now