CHECK / REQUIRE (true==true) fails in Debug Build

[trenki2]

I had code like this and somehow in Debug Build my tests failed:

REQUIRE(task->isTerminated() == false);
REQUIRE(task->isRunning() == false);
REQUIRE(task->execStatus() == Task::Created);

The following tests the scenario just with true and false statements.

#include "catch_with_main.hpp"

ANON_TEST_CASE()
{
    CHECK(false == false); // Fails in Debug!!!
    CHECK(true == true);   // Fails in Debug!!!

    // Extra parenthesis make it work!
    CHECK((false == false));
    CHECK((true == true));

    CHECK_FALSE(false == true);
    CHECK_FALSE(true == false);

    // Extra parenthesis make it fail!
    CHECK_FALSE((false == true)); // Fails in Debug!!!
    CHECK_FALSE((true == false)); // Fails in Debug!!!
}

[philsquared]

That's really bizarre.
AFAICS it only does this for the latest version, in MSVC++, in debug mode.

But I think I have found the cause (but have run out of time to fix it this morning - will have to do that this evening).

I recently added an overload for expression components that are bools that take the bool by value instead of by const ref. This was to prevent a case where expressions with undefined types were being evaluated when they didn't need to be.

However, that (now local value) bool is being held between calls by const ref - so it's now referencing an out-of-scope value!

It's amazing (and unfortunate) it's taken so long to show, but such is the nature of these things. My apologies to the community for letting such a schoolboy error slip through.

Will have it fixed as soon as possible.

[philsquared]

I've checked in my "fix". However I won't have access to VC++ again until tomorrow so I've only been able to verify that it doesn't break on my gcc/ XCode set-up.
If anyone has a chance to verify with VC++ before I do please let us know here.

[trenki2]

I just tested the updated CATCH version with the test cases that I provided above and they now succeed in Release and Debug mode for VC++ 2008 Express!

[philsquared]

Thanks @trenki2.

I've just been able to verify it in VS2008 too.
Although there seems to be a bug in GitHub at the moment where every time I try to upload a new version of the single_include header as a separate download it reverts to the previous version!
I presume you were using the repos version?

[trenki2]

Yes, I simply downloaded the new zip archive.