Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #435 by adding a break #436

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Fix #435 by adding a break #436

merged 1 commit into from
Sep 29, 2021

Conversation

tkadlec
Copy link
Contributor

@tkadlec tkadlec commented Sep 29, 2021

Looks like issue #435 was caused by an over eager set of for loops that simply needed a break when a match occurred so that the same request couldn't be matched to multiple requests in the logs.

@scottjehl
Copy link

aw. we all need a break sometimes, py

@tkadlec
Copy link
Contributor Author

tkadlec commented Sep 29, 2021

Basic gist here for anyone following along:

  • We collect requests via an extension
  • We also collect requests via underlying logs

We then loop through the extension requests to merge them with the requests from the logs, so that we can get more information.

Since we never broke the loop, it was possible for the same extension request to be matched to multiple log requests.

@tkadlec tkadlec merged commit b68a69c into master Sep 29, 2021
@scottjehl scottjehl deleted the 435 branch September 29, 2021 15:35
@scottjehl
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants