Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly handle error response codes when a target disappears #443

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

pmeenan
Copy link
Contributor

@pmeenan pmeenan commented Oct 19, 2021

This fixes an unnecessary delay when trying to retrieve response bodies from a target that has disappeared. Chrome returns an error to the outer dev tools command but we previously always expected it to succeed so it has to time out the command.

This should speed up testing a bit (encountered it while testing some wappalyzer updates).

@pmeenan pmeenan merged commit 531f135 into catchpoint:master Oct 20, 2021
@pmeenan pmeenan deleted the fastfail branch October 20, 2021 15:49
@tkadlec
Copy link
Contributor

tkadlec commented Oct 21, 2021

Thanks @pmeenan! Had done some profiling of the agent and Wappalyzer was one of, if not the, most expensive parts. Was looking at making it optional, but I'll run a few tests and see how much faster this made things first.

@pmeenan
Copy link
Contributor Author

pmeenan commented Oct 21, 2021

This fix should have been independent and won't make wappalyzer faster, sadly. It is mostly around getting response bodies where it seemed to trigger the error. Making wappalyzer optional makes 100% sense.

@tkadlec
Copy link
Contributor

tkadlec commented Oct 21, 2021

Ah, gotcha. Sorry...misread the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants