Add trusted mouseClick command to WPT #654
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @mjkozicki , @claud-io , would appreciate if you could review this PR and provide feedback. This should be a useful command to run true interactivity tests with Event timing metrics. |
|
@pmeenan / @vibaldem FYI, this PR is for catchpoint/WebPageTest#3048 and catchpoint/WebPageTest#3049 . |
|
@pmeenan, please take a look. |
pmeenan
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing click and clickAndWait WPT commands are JavaScript initiated events which are synthetic. Hence "Trusted" flag for JS events is set to false. Such events get ignored by EventTiming API (https://www.w3.org/TR/event-timing/). This problem was issued catchpoint/WebPageTest#3048
Moreover, WPT click command does not support right and double click; mentioned in catchpoint/WebPageTest#3049 .
We have created a new mouseClick command with the following format which supports left, right and double click:
mouseClick [tab] Id| selector [tab] left|right|double
The new command uses Devtools Protocol (https://chromedevtools.github.io/devtools-protocol/tot/Input/) input domain to dispatch Trusted mousepressed and mousereleased events.