Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for some if not all Custom Scripting to apply alongside experiments #2132

Open
scottjehl opened this issue Jul 13, 2022 · 2 comments
Open

Allow for some if not all Custom Scripting to apply alongside experiments #2132

scottjehl opened this issue Jul 13, 2022 · 2 comments
Labels
Type: Enhancement An improvement to WebPageTest

Comments

@scottjehl
Copy link
Contributor

Currently, experiment scripts run in place of any scripting that's applied to a test. Many scripting features should be compatible with experiments, while some (like multistep tests) may not.

We should aim to preserve scripting in experiments.
@scottjehl scottjehl added the Type: Enhancement An improvement to WebPageTest label Jul 13, 2022
@scottjehl scottjehl mentioned this issue Jul 13, 2022
Closed
scottjehl added a commit that referenced this issue Jul 15, 2022
@scottjehl
this borrows the custom headers addition from up top too, bringing th…
d6be32f 
…eir support to experiments.

Note: these changes will still not preserve a test['script'] field at all. They simply re-apply customHeaders and auth into the new script we're creating for an experiment. #2132
@scottjehl scottjehl mentioned this issue Jul 15, 2022
Merged
tkadlec added a commit that referenced this issue Jul 15, 2022
@tkadlec
Merge pull request #2159 from WPO-Foundation/2132
af14513 
this fixes #2132 for basic auth specifically, but is not yet optimized. This logic could stand to be central and shared
@kevinfarrugia
Copy link

kevinfarrugia commented Aug 1, 2022 •
edited

This ticket was closed but scripts are still not being copied onto experiments.

Example: https://www.webpagetest.org/video/compare.php?tests=220801_AiDcWC_539,220801_AiDc2D_537

navigate %url%/learn

@scottjehl
Copy link
Contributor Author

Thanks @kevinfarrugia

This was partly addressed but you're right that it's not fully fixed yet. We intend to keep what we can of scripts, but some settings will have to be overridden for the experiment itself (which also uses scripting).

@scottjehl scottjehl reopened this Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement An improvement to WebPageTest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scottjehl @kevinfarrugia