Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For homepage variations like CWV, Compare, Tracerout, Lighthouse, we're not setting nav state and content include is broken #2334

Closed
scottjehl opened this issue Sep 7, 2022 · 0 comments
Assignees

Comments

@scottjehl
Copy link
Contributor

Seems like two issues here, possibly a regression from when we started varying the homepage content for pro users.

First, the Start Test state in the nav should be set for all these pages, and it seems they never were. This isn't a regression but we can fix it like this:

https://github.com/WPO-Foundation/webpagetest/blob/7e85dc41099d1fa5fb4451f912954dae73bb4529/www/webvitals.php#L45
This line should be $tab = "Start Test";

Second, when you're logged in as PRO, the content header is not there on these pages. I think all that is needed is these pages need a body class of <body class="home feature-pro">

@scottjehl scottjehl self-assigned this Sep 7, 2022
scottjehl added a commit that referenced this issue Sep 7, 2022
scottjehl added a commit that referenced this issue Sep 7, 2022
scottjehl added a commit that referenced this issue Sep 7, 2022
scottjehl added a commit that referenced this issue Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant