Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to pass current test ID into custom scripts #2373

Closed
tkadlec opened this issue Sep 23, 2022 · 1 comment
Closed

Ability to pass current test ID into custom scripts #2373

tkadlec opened this issue Sep 23, 2022 · 1 comment
Labels
Type: Enhancement An improvement to WebPageTest

Comments

@tkadlec
Copy link
Contributor

tkadlec commented Sep 23, 2022

Feature Request Summary

The ability to use the current test ID in custom scripts with variable substitution (ex: %TESTID%)

What's the motivation or use case for the change/feature?

We already let folks append the test ID to the ua string, but making it available in the custom scripts means they could do things like append the ID as a query parameter so that they can dig into the tracing/logs on their own architecture to follow the path of the test more clearly.

We currently do our substitution here: https://github.com/WPO-Foundation/webpagetest/blob/5378d7aecd9033174598640339d84ae37c804943/www/runtest.php#L3441
@tkadlec tkadlec added the Type: Enhancement An improvement to WebPageTest label Sep 23, 2022
@sammeboy635 sammeboy635 mentioned this issue Sep 27, 2022
Merged
@tkadlec
Copy link
Contributor Author

tkadlec commented Oct 5, 2022

closed by #2381

@tkadlec tkadlec closed this as completed Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement An improvement to WebPageTest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tkadlec