Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Page and Request Summary CSV files #1740

Merged
merged 2 commits into from
Feb 7, 2022
Merged

Conversation

paulcalvano
Copy link
Contributor

Add Page and Request Summary CSV files to the Export menu

This fixes #1739

Add Page and Request Summary CSV files to the Export menu
Copy link
Contributor

@tkadlec tkadlec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @paulcalvano!

Both these lines will need to be wrapped in double quotes (") rather than single (') for the variable interpolation to work.

So like this:

echo "<li><a href=\"/csv.php?test=$id\">Download Page CSV</a></li>";

Once that's fixed, we can ship this. :)

@tkadlec tkadlec merged commit ce64ac0 into catchpoint:master Feb 7, 2022
@tkadlec
Copy link
Contributor

tkadlec commented Feb 7, 2022

Thanks, @paulcalvano!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSV files are missing from the Export Menu
2 participants