Make screen-read locations less repetitive #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous markup looked like: ```html <span class="test_presets_tag"><img src="/images/test_icons/flags/US.svg" alt="Virginia, USA " title="Virginia, USA ">Virginia, USA </span> ``` While `alt` and `title` are normally helpful for solitary icons, in this case the location is displayed as plain text next to the flag. Screen readers would repeat the location name at least twice, and up to 3 times depending on verbosity settings. The tooltip functionality of `title` was also suppressed by the wrapping `<label>` and/or the custom hover bubbles, so removing it should change nothing.
|
Agreed! Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous markup looked like:
While
altandtitleare normally helpful for solitary icons, in this case the location is displayed as plain text next to the flag. Screen readers would repeat the location name at least twice, and up to 3 times depending on verbosity settings.The tooltip functionality of
titlewas also suppressed by the wrapping<label>and/or the custom hover bubbles, so removing it should change nothing.