Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tip for Scott Jehl's video course #2104

Merged
merged 6 commits into from
Jul 7, 2022
Merged

Added tip for Scott Jehl's video course #2104

merged 6 commits into from
Jul 7, 2022

Conversation

stoyan
Copy link
Contributor

@stoyan stoyan commented Jul 7, 2022

I think it's a good tip to have. I'm just not sure about the click tracking. Added lfwp mimicking other tips, but not sure if there's an other setup required on the analytics side.

@deathbearbrown
Copy link
Contributor

I'd squash this with a rebase
git rebase -i HEAD~4
You will put an s in front of each commit hash you want to squash up into the previous, then you will be able to edit the commit message.
After that you will need to do a force push to master because you played god and modified the timeline.

For your adr PR, I would branch off a clean master (post merging this to the wpo project & pulling to your fork) git checkout -b adr-jquery save the file and push that up to PR.

ADR to remove jQuery and jQuery UI dependencies

Revert "ADR to remove jQuery and jQuery UI dependencies"

This reverts commit 7659af7.
@deathbearbrown
Copy link
Contributor

perfect!

@stoyan stoyan merged commit aec9911 into catchpoint:master Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants