Make render-blocking requests for css and js more reliable in browsers that do not provide that information #2217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck render. This is not a guarantee, as these may have been added dynamically by the time this runs. Still, we can use this list to compare in browsers that don't send a render-blocking flag on requests, so we can be more confident that a request that arrived before start render was actually render-blocking. Browsers such as chromium currently give us that information directly so we do not need this in those browsers.
…ss and js requests in opportunities fixes #2216
|
nit: could you run |
tkadlec
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds and utilizes a new custom metric that collects scripts and links in the page that have render-blocking qualities.
This list is not a guarantee to contain render-blockers, as these may have been added dynamically by the time this runs. Still, we can use this list to compare in browsers that don't send a render-blocking flag on requests, so we can be more confident that a request that arrived before start render was actually render-blocking. Browsers such as chromium currently give us that information directly so we do not need this in those browsers.