Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tag-label design #2237

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Conversation

anthonyandersonfg
Copy link
Contributor

The tag label does not display the text properly if the text has more than 21 characters:

image

To fix the problem I added the white-space: nowrap; to the tag class:

image

But even though the text is larger than the container, the ellipsis is not being displayed:

image

That's because the text-overflow: ellipsis; is not working properly for this tag, because it is assigned as a flex element, and text-overflow works for block elements only
To fix I have added the display: inline-block !important.

That's how the tag will look when a text overflow occurs:

image

@tkadlec tkadlec requested a review from scottjehl August 3, 2022 14:27
@scottjehl
Copy link
Contributor

This is a great tip. We can sort out our own use of !important here that this is repeating in a later cleanup. Thanks!

@scottjehl scottjehl merged commit 7e1a808 into catchpoint:master Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants