Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pagestyle2.css: dead code is dead #2385

Merged
merged 1 commit into from
Oct 4, 2022
Merged

pagestyle2.css: dead code is dead #2385

merged 1 commit into from
Oct 4, 2022

Conversation

stoyan
Copy link
Contributor

@stoyan stoyan commented Sep 29, 2022

15% fewer LOC (8415 down from 9924)

Removed:

  • commented out code
  • empty selectors
  • properties overwritten by shorthands, e.g. padding-left followed by padding
  • duplicate properties
  • alpha() opacity

Added:

  • generic font families where missing (mostly in jQuery stuff)

scottjehl
scottjehl approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@scottjehl scottjehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@stoyan
Copy link
Contributor Author

stoyan commented Oct 4, 2022

updated and resolved conflicts

@stoyan stoyan merged commit 93a776c into master Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottjehl scottjehl scottjehl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stoyan @scottjehl