CustomWaterfall: add min functionality #3057
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @mjkozicki , @claud-io , would appreciate if you could review this PR and provide feedback. |
pmeenan
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
LGTM.
Minimum time feels a bit off and Start seems more appropriate but given that the end is called Maximum it is appropriate to keep it aligned.
Thanks for doing this, it's been a long-standing request and I've been dreading going through the scaling code. The change looks nice and clean.
|
@mjkozicki ...PING... Can you review (and merge if things look good)? |
|
@mjkozicki @claud-io ...PING, PING... Can you review (and merge if things look good)? |
|
Hello @jspurlin we are testing it, will let you know once is done. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR users could only set a max time to filter on when creating custom waterfalls. This meant that custom waterfalls always started at t=0 even if what you cared about didn't start until the t=5s mark
This PR adds the ability to optionally specify a min time to filter on in addition to setting a max and requests to filter on.
I verified that the custom filter scales correctly in app parts (Requests, CUP Utilization, Bandwidth, Browser Main Thread, and Long Tasks)
For example, if I care about the 5-10s range of the waterfall this is what it looks like
Before
After
This is a fix for Add ability to specify min/start time for custom waterfalls #3042