Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON output type to grandma diff #198

Open
gsf4726 opened this issue Apr 10, 2020 · 2 comments
Open

Add JSON output type to grandma diff #198

gsf4726 opened this issue Apr 10, 2020 · 2 comments

Comments

@gsf4726
Copy link

gsf4726 commented Apr 10, 2020

Currently grandma.diff output only supports tabular text like:

Latencies:  mean               50                 95                 99                 max

run: someTest, 10s, 1 concurrent, 3 total
fullTest    4650.651ms (-35%)  4686.128ms (-33%)  4880.873ms (-33%)  4880.873ms (-33%)  4880.873ms (-33%)

bench: someTest, 10s, 1 concurrent, 3 total
fullTest    3456.642ms         3527.152ms         3674.297ms         3674.297ms         3674.297ms

Adding a JSON output option would make it easier for an automated process to handle the results.

@catdad
Copy link
Owner

catdad commented Apr 10, 2020

Hmm... what info are you interested in having in a JSON diff? You can already get a JSON for individual runs. What would a diff JSON look like?

@gsf4726
Copy link
Author

gsf4726 commented Apr 10, 2020

Was primarily thinking, to implement a failure threshold in automation, it'd be convenient to get the deltas that are currently reported in the diff text output.

Certainly a convenience though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants