Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(aspect models): Fix aspect model diagram display and aspect model file download #426

Conversation

ds-lcapellino
Copy link

@ds-lcapellino ds-lcapellino commented Mar 4, 2024

Description

This will fix the described error in eclipse-tractusx#446.

Why

Diagrams were not displayed properly and file download weren't handled correctly.

Issue

eclipse-tractusx#446

Checklist

Please delete options that are not relevant.

  • I have followed the contributing guidelines
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes

Copy link

github-actions bot commented Mar 4, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

Unknown release type "Fix" found in pull request title "Fix(aspect models): Fix aspect model diagram display and aspect model file download". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

Copy link

sonarcloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@evegufy
Copy link
Collaborator

evegufy commented Mar 5, 2024

Hi @ds-lcapellino thank you! could you please raise the PR to the dev branch in eclipse-tractusx https://github.com/eclipse-tractusx/portal-frontend/pulls?

@ds-lcapellino
Copy link
Author

Hi @evegufy,
thank you for your response, please see the PR for the eclipse-tractusx dev branch: eclipse-tractusx#589

ajithsimons pushed a commit to ajithsimons/tx-portal-frontend that referenced this pull request Mar 22, 2024
@evegufy evegufy closed this May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants