feature(policy): #832 fix code issues

catenax-ng · Jun 12, 2024 · 2e73975 · 2e73975
1 parent d6c5e04
commit 2e73975
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 7 deletions.
diff --git a/...rc/app/modules/page/admin/presentation/policy-management/policies/policies.component.scss b/...rc/app/modules/page/admin/presentation/policy-management/policies/policies.component.scss
diff --git a/.../src/app/modules/page/admin/presentation/policy-management/policies/policies.component.ts b/.../src/app/modules/page/admin/presentation/policy-management/policies/policies.component.ts
@@ -22,7 +22,7 @@ import { take } from 'rxjs/operators';
 @Component({
   selector: 'app-policies',
   templateUrl: './policies.component.html',
-  styleUrls: [ './policies.component.scss' ],
+  styleUrls: [],
 })
 export class PoliciesComponent {
   policiesView$: Observable<View<Policy[]>>;

diff --git a/...nd/src/app/modules/page/admin/presentation/policy-management/policies/policy.assembler.ts b/...nd/src/app/modules/page/admin/presentation/policy-management/policies/policy.assembler.ts
@@ -79,6 +79,7 @@ export class PoliciesAssembler {
     return constrainsList;
   }
 
+  /*
   public static validatePoliciesTemplate(data: any) {
 
     if (typeof data !== 'object' || data === null || !Array.isArray(data[Object.keys(data)[0]])) {
@@ -155,4 +156,6 @@ export class PoliciesAssembler {
     return true;
   }
 
+   */
+
 }
diff --git a/...ules/page/admin/presentation/policy-management/policy-editor/policy-editor.component.html b/...ules/page/admin/presentation/policy-management/policy-editor/policy-editor.component.html
@@ -92,6 +92,7 @@
       >
         <app-button [variant]="'raised'" [color]="'primary'"
                     (click)="applyTemplate()"
+                    onkeydown="applyTemplate()"
                     [isDisabled]="!templateFile"
                     class="mr-2"
         >{{ 'pageAdmin.policyManagement.apply' | i18n }}
@@ -148,6 +149,7 @@ <h4 class="pb-2">{{ 'pageAdmin.policyManagement.constraints' | i18n }} {{ '(' +
              class="mb-2" *ngIf="viewMode !== ViewMode.VIEW">
           <app-button
             [iconName]="'add'"
+            onkeydown="addConstraintFormGroup()"
             (click)="addConstraintFormGroup()"
           ></app-button>
         </div>
@@ -199,6 +201,7 @@ <h4 class="pb-2">{{ 'pageAdmin.policyManagement.constraints' | i18n }} {{ '(' +
               >
                 <app-button
                   [iconName]="'arrow_downward'"
+                  onkeydown="moveConstraintDown(i)"
                   (click)="moveConstraintDown(i)"
                 >
                 </app-button>
@@ -213,6 +216,7 @@ <h4 class="pb-2">{{ 'pageAdmin.policyManagement.constraints' | i18n }} {{ '(' +
 
                 <app-button
                   [iconName]="'arrow_upward'"
+                  onkeydown="moveConstraintUp(i)"
                   (click)="moveConstraintUp(i)"
                 >
                 </app-button>
@@ -226,6 +230,7 @@ <h4 class="pb-2">{{ 'pageAdmin.policyManagement.constraints' | i18n }} {{ '(' +
               >
                 <app-button
                   [iconName]="'delete'"
+                  onkeydown="removeConstraintFormGroup(i)"
                   (click)="removeConstraintFormGroup(i)"
                 >
                 </app-button>

diff --git a/frontend/src/app/modules/page/policies/model/policy.model.ts b/frontend/src/app/modules/page/policies/model/policy.model.ts
@@ -121,22 +121,16 @@ export function getOperatorTypeSign(type: OperatorType): string {
   switch (type) {
     case OperatorType.EQ:
       return '=';
-      break;
     case OperatorType.NEQ:
       return '!=';
-      break;
     case OperatorType.LT:
       return '<';
-      break;
     case OperatorType.GT:
       return '>';
-      break;
     case OperatorType.LTEQ:
       return '<=';
-      break;
     case OperatorType.GTEQ:
       return '>=';
-      break;
     default:
       return type.toString();
   }

diff --git a/frontend/src/app/modules/shared/components/table/table.component.html b/frontend/src/app/modules/shared/components/table/table.component.html
@@ -90,6 +90,7 @@
         <app-button
           [iconName]="'delete'"
           (click)="handleItemDeletion()"
+          onkeydown="handleItemDeletion()"
           [isDisabled]="selection.selected.length < 1"
         >
         </app-button>