Chore-XXX: Fixed jsonSchemaTest #1282
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tx-backend/src/test/java/org/eclipse/tractusx/traceability/JsonSchemaTest.java
Fixed
Show fixed
Hide fixed
tx-backend/src/test/java/org/eclipse/tractusx/traceability/JsonSchemaTest.java
Fixed
Show fixed
Hide fixed
tx-backend/src/test/java/org/eclipse/tractusx/traceability/JsonSchemaTest.java
Fixed
Show fixed
Hide fixed
Integration Test Results345 tests 345 ✅ 1m 34s ⏱️ Results for commit 4d01e87. ♻️ This comment has been updated with latest results. |
Unit Test Results208 tests 208 ✅ 18s ⏱️ Results for commit 4d01e87. ♻️ This comment has been updated with latest results. |
✅ No Dependency Check findings were found |
| if (highestVersionFile == null) { | ||
| throw new IOException("No suitable file found"); | ||
| } |
There was a problem hiding this comment.
Since this is a test, there is no need to throw Exceptions. Maybe use assertNotNull.
| @Test | ||
| public void test() throws IOException { | ||
| public void test() throws IOException, URISyntaxException { |
There was a problem hiding this comment.
Please add an appropriate method name
| file | ||
| ); | ||
|
|
||
|
|
||
| List<String> strings = isValid(multipartFile); |
There was a problem hiding this comment.
Use an appropriate variable name instead of strings
tx-backend/pom.xml
Outdated
| <artifactId>maven-resources-plugin</artifactId> | ||
| <version>3.2.0</version> | ||
| <executions> | ||
| <execution> |
There was a problem hiding this comment.
Put execution into the already existing plugin.
| for (String string : strings) { | ||
| log.info(string); | ||
| } | ||
| public void testJsonSchema() { |
|
|
No description provided.