Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/TRACEFOSS-2512 Frontend/Backend Global Search #636

Merged
merged 19 commits into from
Oct 5, 2023

Conversation

ds-mwesener
Copy link

No description provided.

@ds-mwesener ds-mwesener changed the title Feature/tracefoss 2512 global search feature/TRACEFOSS-2512 Frontend Global Search Oct 4, 2023
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Integration Test Results

212 tests   212 ✔️  1m 58s ⏱️
  30 suites      0 💤
  30 files        0

Results for commit a47ad03.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Unit Test Results

219 tests   216 ✔️  29s ⏱️
  51 suites      3 💤
  51 files        0

Results for commit a47ad03.

♻️ This comment has been updated with latest results.

…ACEFOSS-2512-global-search

# Conflicts:
#	frontend/src/app/modules/page/parts/presentation/parts.component.ts
# Conflicts:
#	frontend/src/app/modules/page/parts/presentation/parts.component.ts
@ds-mwesener ds-mwesener changed the title feature/TRACEFOSS-2512 Frontend Global Search feature/TRACEFOSS-2512 Frontend/Backend Global Search Oct 4, 2023
ds-ext-sceronik
ds-ext-sceronik previously approved these changes Oct 4, 2023
Copy link

@ds-ext-sceronik ds-ext-sceronik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@ds-mwesener ds-mwesener marked this pull request as ready for review October 5, 2023 11:06
Comment on lines 94 to 96
this.searchFormGroup.valueChanges.subscribe((formValues) => {
console.log("Change", formValues);
});
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this


private resetLocalFilters(filterIsSet: boolean) {
for (const partTableComponent of this.partsTableComponents) {
if (partTableComponent.multiCompo.theSearchElement) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe consider rename of multicompo

this.selectionChange.emit(this.selectedValue);
this.theSearchElement = val.value;
console.log("selection change");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete

@ds-mmaul
Copy link

ds-mmaul commented Oct 5, 2023

[Trace-X Root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs Vulnerability A 0 Vulnerabilities Security Hotspot A 0 Security Hotspots Code Smell A 5 Code Smells

88.7% 88.7% Coverage 0.0% 0.0% Duplication

check code smells

Copy link

@ds-mmaul ds-mmaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

[TX Traceability FOSS frontend] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

83.8% 83.8% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

[Trace-X Root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

88.7% 88.7% Coverage
0.0% 0.0% Duplication

@ds-mwesener ds-mwesener merged commit 4b7d5b3 into main Oct 5, 2023
21 checks passed
@ds-mwesener ds-mwesener deleted the feature/TRACEFOSS-2512-global-search branch October 5, 2023 11:40
ds-lcapellino added a commit that referenced this pull request Mar 28, 2024
ds-lcapellino added a commit that referenced this pull request Mar 28, 2024
ds-lcapellino added a commit that referenced this pull request Mar 28, 2024
ds-lcapellino added a commit that referenced this pull request Mar 28, 2024
ds-lcapellino added a commit that referenced this pull request Apr 2, 2024
ds-lcapellino added a commit that referenced this pull request Apr 2, 2024
ds-lcapellino added a commit that referenced this pull request Apr 2, 2024
ds-lcapellino added a commit that referenced this pull request Apr 3, 2024
ds-lcapellino added a commit that referenced this pull request Apr 3, 2024
ds-lcapellino added a commit that referenced this pull request Apr 3, 2024
ds-lcapellino added a commit that referenced this pull request Apr 3, 2024
ds-lcapellino added a commit that referenced this pull request Apr 3, 2024
ds-lcapellino added a commit that referenced this pull request Apr 4, 2024
ds-lcapellino added a commit that referenced this pull request Apr 4, 2024
ds-lcapellino added a commit that referenced this pull request Apr 4, 2024
ds-lcapellino added a commit that referenced this pull request Apr 4, 2024
ds-lcapellino added a commit that referenced this pull request Apr 4, 2024
ds-lcapellino added a commit that referenced this pull request Apr 5, 2024
feature: #636 udpate registry from 0.3.22 to 0.4.9-RC2
ds-mwesener added a commit that referenced this pull request Apr 5, 2024
…registry-version-with-client-lib

feature: #636 implement irs-edc-client 1.7.0-SNAPSHOT to migrate to r…
ds-lcapellino added a commit that referenced this pull request Apr 10, 2024
…registry

Revert "feature: #636 udpate registry from 0.3.22 to 0.4.9-RC2"
ds-lcapellino added a commit that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants