Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/xxx fixed publish documentation workflow #983

Merged
merged 24 commits into from
Feb 21, 2024

Conversation

ds-ashanmugavel
Copy link

@ds-ashanmugavel ds-ashanmugavel commented Feb 14, 2024

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a short description of the feature/fix to the Changelog.md.

Copy link

github-actions bot commented Feb 14, 2024

Integration Test Results

319 tests   319 ✅  1m 8s ⏱️
 37 suites    0 💤
 37 files      0 ❌

Results for commit 032035a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Feb 14, 2024

Unit Test Results

216 tests   216 ✅  20s ⏱️
 54 suites    0 💤
 54 files      0 ❌

Results for commit 331ef84.

♻️ This comment has been updated with latest results.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a short description of the feature/fix to the Changelog.md.

Copy link

github-actions bot commented Feb 14, 2024

‼️ Dependency Check findings ‼️

One or more high/critical findings have been found during dependency check. Please check the depenency report:
https://github.com/catenax-ng/tx-traceability-foss/actions/runs/7987080822

ds-mwesener
ds-mwesener previously approved these changes Feb 19, 2024
Copy link

@ds-mwesener ds-mwesener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ds-ashanmugavel currently the dependency check fails. Please fix that then we can merge your changes. Thank you!

CHANGELOG.md Outdated
@@ -30,6 +30,8 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
- IrsCallbackController is now validating jobId to prevent log injections from unwanted usage
- Changed Add Parts concept to Edit Parts concept

- updated publish-documentation workflow with two new steps

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this changelog entry to the top, so it is listed below "UNRELEASED". This probably happened by merging the main into your branch

Copy link

@ds-lcapellino ds-lcapellino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ds-lcapellino ds-lcapellino merged commit e1008f9 into main Feb 21, 2024
17 of 18 checks passed
@ds-lcapellino ds-lcapellino deleted the chore/xxx-publish_documentation_workflow branch February 21, 2024 09:52
Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed for 'Trace-X Root'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed for 'TX Traceability FOSS frontend'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

ds-mwesener added a commit that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants