Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

list: Catch catkin_pkg.package.InvalidPackage error when getting package info #76

Closed
jbohren opened this issue Jun 30, 2014 · 4 comments · Fixed by #79
Closed

list: Catch catkin_pkg.package.InvalidPackage error when getting package info #76

jbohren opened this issue Jun 30, 2014 · 4 comments · Fixed by #79

Comments

@jbohren
Copy link
Contributor

jbohren commented Jun 30, 2014

[yavin:~/ws/hydro/underlay]$ catkin list
Traceback (most recent call last):
  File "/usr/local/bin/catkin", line 9, in <module>
    load_entry_point('catkin-tools==0.1.0', 'console_scripts', 'catkin')()
  File "/usr/local/lib/python2.7/dist-packages/catkin_tools-0.1.0-py2.7.egg/catkin_tools/commands/catkin.py", line 192, in main
    sys.exit(args.main(args) or 0)
  File "/usr/local/lib/python2.7/dist-packages/catkin_tools-0.1.0-py2.7.egg/catkin_tools/verbs/catkin_list/cli.py", line 38, in main
    for pkg_pth, pkg in find_packages(folder).items():
  File "/usr/lib/pymodules/python2.7/catkin_pkg/packages.py", line 83, in find_packages
    packages = find_packages_allowing_duplicates(basepath, exclude_paths=exclude_paths, exclude_subspaces=exclude_subspaces)
  File "/usr/lib/pymodules/python2.7/catkin_pkg/packages.py", line 109, in find_packages_allowing_duplicates
    packages[path] = parse_package(os.path.join(basepath, path))
  File "/usr/lib/pymodules/python2.7/catkin_pkg/package.py", line 356, in parse_package
    return parse_package_string(f.read(), filename)
  File "/usr/lib/pymodules/python2.7/catkin_pkg/package.py", line 374, in parse_package_string
    raise InvalidPackage('The manifest contains invalid XML:\n%s' % ex)
catkin_pkg.package.InvalidPackage: Invalid package manifest "/home/jbohren/ws/hydro/underlay/devel/lib/ruby/1.8/x86_64-linux/orogen/templates/typekit/package.xml": The manifest contains invalid XML:
not well-formed (invalid token): line 2, column 9
@wjwwood
Copy link
Member

wjwwood commented Jun 30, 2014

/home/jbohren/ws/hydro/underlay/devel/lib/ruby/1.8/x86_64-linux/orogen/templates/typekit/package.xml Is not a valid package.xml.

It should have a CATKIN_IGNORE file next to it if it isn't meant to be processed.

@wjwwood
Copy link
Member

wjwwood commented Jun 30, 2014

I don't believe this is a catkin_tools error, unless you want to improve the error behavior.

So I would I ask you to either close the issue, or change the issue to provide a pull request or to suggest how to improve it.

@jbohren
Copy link
Contributor Author

jbohren commented Jun 30, 2014

It should have a CATKIN_IGNORE file next to it if it isn't meant to be processed.

Yeah it should. There is one in the source tree, so it doesn't cause a problem there, but it doesn't get installed. That will change.

I don't believe this is a catkin_tools error, unless you want to improve the error behavior.

Yeah, I'll follow this up with a PR.

@jbohren
Copy link
Contributor Author

jbohren commented Jul 3, 2014

PR in #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants