Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version ranges and geq condition for any_version in rules files #10

Open
NikolausDemmel opened this issue Jul 18, 2014 · 3 comments
Open
Assignees
Milestone

Comments

@NikolausDemmel
Copy link
Member

Here is a proposal for how to realize this:
http://xylem.readthedocs.org/en/latest/spec.html#any-version-and-version-ranges

This does require os plugins to provide an order on versions for rule lookup, but not for rule file loading / expanding / saving.

Feel free to comment / discuss in this issue.

@NikolausDemmel
Copy link
Member Author

@tfoote
Copy link

tfoote commented Jul 21, 2014

Looks reasonable. I'd also clarify on a collision who wins in a case like this:

precise, raring, utopic: [foo]
any_version>=trust: [bar]

Presumably the explicit rule would take precedence.

@NikolausDemmel
Copy link
Member Author

Yes, the explicit rule you win. I do not want to forbid this, since that would again make rule file parsing dependent on the OS plugin knowledge.

One could argue that the test suite for rosdistro could check and forbid this, but I don't see a real need. Also the following seems reasonable to me:

foo:
  osx:
    any_version>=mavericks:
      homebrew: libfoo
    mavericks:
      macports: libfoo-1
    yosemite:
      macports: libfoo-2

@NikolausDemmel NikolausDemmel self-assigned this Aug 10, 2014
@NikolausDemmel NikolausDemmel added this to the 0.1.0 Release milestone Aug 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants