Bug 1045730 - Add task-specific configuration to Runner #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for try_num in range(1, config.max_tries + 1): | ||
| for t in tasks: | ||
| log.debug("%s: starting (max time %is)", t, max_time) | ||
| r = run_task(os.path.join(dirname, t), env, max_time=max_time) | ||
| tasks_config = { |
There was a problem hiding this comment.
how about default_config = {... }
There was a problem hiding this comment.
you have no idea how long i spent trying to figure out a name for this without success
catlee
added a commit
that referenced
this pull request
Jul 30, 2014
Bug 1045730 - Add task-specific configuration to Runner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be what we want.
Bonus: removed packaging/deployment from README as that was done weeks ago! (also hey look emoji in git commit messages!)