-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"replay this map" doesn't indicate gametype #5
Comments
Hi, you probably have too few maps left in the rotation. Add one more map to the rotation and you should have 4 maps displayed. You need to have at least 4 unique maps left in the rotation. |
@cato-a Here it is : |
Yes you have 4 unique maps, but one map is used for "replay this map", so you only have 3 unique maps left in the rotation. |
I just realized that the two replay choices are the same gametype. I'm trying to change that and will make a pull request if I succeed. |
There is no issue here. You need to add 1 more map so that you have enough unique maps in the rotation (4 unique maps in rotation + "replay this map" = 5 unique maps in total). For the rotation to work you need to have a minimum of 5 unique maps. |
For my servers, I want all the possibilities to be displayed in mapvote, so I have 5 in maprotation. Here is how it looks on the maps that are not the one included twice : And here is how it looks on the map included twice : For me it's a problem that's why I try to modify the behavior. |
Yes, I understand, but MiscMod support unique maps, not duplicate maps. The bug is rather duplicate maps show up in the vote if the gametype is different. So "replay this map" and "mystery map" will remove any non-unique maps. So to do what you want you must edit Find this code and comment it out/delete (line 465/466): if(codam\_mm_mmm::in_array(mapRotation, level.mmmapname))
mapRotation = codam\_mm_mmm::array_remove(mapRotation, level.mmmapname, true); Replace (from line 502) with something like this: case "map":
if((i + 1) < mapRotation.size
&& (lastgt != level.mmgametype || mapRotation[i + 1] != level.mmmapname)) {
_tmp[_tmp.size]["gametype"] = lastgt;
_tmp[_tmp.size - 1]["map"] = mapRotation[i + 1];
}
i += 2;
break; Try it out and see if it works. |
I thank you very much for your help, I tried after modifying On the duplicated map (zh_king) DM, here is how it looks now : When voted for the SD version, the game goes back to main menu without trying to load the map and displays this error : It seems there is no problem after entering On the duplicated map SD, here is how it looks now : When voted for the DM version, the team menu appears (like just arrived on the server), without loading the map. I will try to fix that, if I succeed I will explain here how I done it. |
It looks that |
Different objects are precached in DM and SD gametype, so when it doesn't do a full map reload you get kicked out if those precaches are missing. It seems it doesn't do a full map reload when the rotation goes to same map. It works from SD to DM because all the objects DM needs are precached in SD.
At least the code I made for you worked. |
Thank you very much, it works now. Here is how I done it : I will probably create a repository if I make something powerful, such as reading maprotation instead of having to manually detect maps etc |
Hello
A map is included twice in the
mapRotation
of my server, with differentgametype
On this map,
mapvote
displays twice "replay this map" without indicatinggametype
, as you could see on the following screenshot :On other maps,
mapvote
displays twice the map, indicatinggametype
.Could you do something for that please ?
The text was updated successfully, but these errors were encountered: