Adds About Me Page #22
Conversation
app/helpers/static_pages_helper.rb
Outdated
| @@ -0,0 +1,2 @@ | |||
| module StaticPagesHelper | |||
There was a problem hiding this comment.
Is this file necessary? Don't check in files that aren't used.
There was a problem hiding this comment.
It is not. I'll remove it.
config/routes.rb
Outdated
| @@ -1,4 +1,7 @@ | |||
| Rails.application.routes.draw do | |||
| get 'static_pages/home' | |||
| get 'static_pages/about' | |||
| get 'static_pages/contact' | |||
There was a problem hiding this comment.
These 3 lines should be combined into one namespace. Something like:
namespace :static_pages do
get '/home'
get '/about'
get '/contact'
end| @@ -0,0 +1,15 @@ | |||
| require 'rails_helper' | |||
There was a problem hiding this comment.
Same with this file. It's autogenerated and not needed.
| @@ -0,0 +1,26 @@ | |||
| require 'rails_helper' | |||
|
|
|||
| RSpec.describe StaticPagesController, type: :controller do | |||
There was a problem hiding this comment.
Consider moving to request specs instead of controller specs. Controller specs have been deprecated and request specs load the application in a proper way to check to make sure the controller actions are working correctly.
|
Can you post screenshots of what your pages look like that you're styling? Also, this should have been split into 2 PRs. styling should be separate from controller actions. |
|
Here is the About Me page:
|
|
Here is the Homepage: |
… removed unused files.
I created the StaticPages controller for the
home,about, andcontactpagesabout meandhomepagepages