Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: retrieve userstyles from catppuccin/userstyles #2120

Merged
merged 7 commits into from
Jul 21, 2023

Conversation

sgoudham
Copy link
Contributor

@sgoudham sgoudham commented Jul 21, 2023

This PR supersedes #1981.

I've updated the documentation to clarify what userstyles are if people are looking to create their own ports, as well as using @rubyowo's existing code to pull in metadata from the https://github.com/catppuccin/userstyles repository to link our userstyles.

It's worth mentioning that the CI hasn't been updated to trigger rebuilds off changes to the userstyles repository as @nekowinston is interested in doing this work. In addition to this, I was experimenting with the mermaid diagram by trying to include the userstyle steps. Unfortunately, it's not formatted well so I've chosen to omit it for now.

You can see what it currently looks like below:

stateDiagram-v2
  idea: You have an idea for a port
  idea --> choice

  choice: Have you already completed a draft?
  choice --> is_userstyle: Yes
  choice --> request: No

  request: Open a Port Request discussion
  request --> request_picked_up
  
  request_picked_up: You or somebody else works on a draft
  request_picked_up --> request_complete

  request_complete: The draft is completed to your liking
  request_complete --> draft_complete

  is_userstyle: Is this themed via Stylus?
  is_userstyle --> userstyle_review: Yes
  is_userstyle --> draft_complete: No

  userstyle_review: Submit pull request\nto catppuccin/userstyles
  userstyle_review --> review
  
  draft_complete: Create a Port Review issue
  draft_complete --> review

  review: Review period
  review --> port_adoption

  note right of review
    Community feedback
  end note

  port_adoption: Port adoption
Loading

If this mermaid diagram still seems okay, I'd be happy to include in the docs. Let me know what you think @nekowinston

sgoudham and others added 2 commits July 21, 2023 00:44
@sgoudham sgoudham changed the title docs: remove userstyles & retrieve from catppuccin/userstyles docs: retrieve userstyles from catppuccin/userstyles Jul 21, 2023
@sgoudham sgoudham requested review from nekowinston and a team July 21, 2023 00:11
Copy link
Contributor

@nekowinston nekowinston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. After the README itself gets removed from the PR, it's good to go.

@sgoudham sgoudham changed the title docs: retrieve userstyles from catppuccin/userstyles build: retrieve userstyles from catppuccin/userstyles Jul 21, 2023
@sgoudham sgoudham merged commit 1220f3a into main Jul 21, 2023
1 check passed
@sgoudham sgoudham deleted the refactor/remove-userstyles branch July 21, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants