Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pointer and marker should probably be different colors #11

Open
injust opened this issue Jun 26, 2024 · 1 comment
Open

Pointer and marker should probably be different colors #11

injust opened this issue Jun 26, 2024 · 1 comment

Comments

@injust
Copy link

injust commented Jun 26, 2024

With the default fzf colors, both pointer and marker are red, but the marker is a lighter shade. This makes them easy to differentiate

The Catppuccin theme makes them both the exact same color (e.g. #f5e0dc in Catppuccin Mocha), which is not so great because the pointer and marker appear beside each other in the TUI.

In fzf 0.53.0, the default pointer and marker characters were changed to Unicode bar characters, which makes the problem worse (the default pointer character used to be >).

To demonstrate a more extreme example, I set both pointer and marker characters to the same Unicode bar character.
Screenshot 2024-06-26 at 8 34 58 AM
Screenshot 2024-06-26 at 8 35 41 AM

@injust
Copy link
Author

injust commented Jun 26, 2024

Testing some different colors for the marker with Catppuccin Mocha:

Replacing Rosewater (#f5e0dc) with Lavender (#b4befe):
Screenshot 2024-06-26 at 9 08 58 AM
Doesn't feel like the contrast is enough

Replacing Rosewater (#f5e0dc) with Blue (#89b4fa):
Screenshot 2024-06-26 at 9 07 56 AM
Definitely better now

injust added a commit to injust/dotfiles that referenced this issue Jun 26, 2024
- Marker: Use Blue (`#89b4fa`) instead of Rosewater (`#f5e0dc`) to differentiate from pointer

catppuccin/fzf#11
injust added a commit to injust/dotfiles that referenced this issue Jun 26, 2024
- Marker: Use Blue (`#89b4fa`) instead of Rosewater (`#f5e0dc`) to differentiate from pointer

catppuccin/fzf#11
injust added a commit to injust/dotfiles that referenced this issue Jun 26, 2024
- Marker: Use Blue (`#89b4fa`) instead of Rosewater (`#f5e0dc`) to differentiate from pointer

catppuccin/fzf#11
injust added a commit to injust/dotfiles that referenced this issue Jun 26, 2024
- Marker: Use Blue (`#89b4fa`) instead of Rosewater (`#f5e0dc`) to differentiate from pointer

catppuccin/fzf#11
injust added a commit to injust/dotfiles that referenced this issue Jun 26, 2024
- Marker: Use Blue (`#89b4fa`) instead of Rosewater (`#f5e0dc`) to differentiate from pointer

catppuccin/fzf#11
injust added a commit to injust/dotfiles that referenced this issue Jun 26, 2024
- Marker: Use Blue (`#89b4fa`) instead of Rosewater (`#f5e0dc`) to differentiate from pointer

catppuccin/fzf#11
injust added a commit to injust/dotfiles that referenced this issue Jun 27, 2024
- Marker: Use Blue (`#89b4fa`) instead of Rosewater (`#f5e0dc`) to differentiate from pointer

catppuccin/fzf#11
injust added a commit to injust/dotfiles that referenced this issue Jun 27, 2024
- Marker: Use Blue (`#89b4fa`) instead of Rosewater (`#f5e0dc`) to differentiate from pointer

catppuccin/fzf#11
injust added a commit to injust/dotfiles that referenced this issue Jun 27, 2024
- Marker: Use Blue (`#89b4fa`) instead of Rosewater (`#f5e0dc`) to differentiate from pointer

catppuccin/fzf#11
injust added a commit to injust/dotfiles that referenced this issue Jun 29, 2024
- Marker: Use Blue (`#89b4fa`) instead of Rosewater (`#f5e0dc`) to differentiate from pointer

catppuccin/fzf#11
injust added a commit to injust/dotfiles that referenced this issue Jun 29, 2024
- Marker: Use Blue (`#89b4fa`) instead of Rosewater (`#f5e0dc`) to differentiate from pointer

catppuccin/fzf#11
injust added a commit to injust/dotfiles that referenced this issue Jun 30, 2024
- Marker: Use Blue (`#89b4fa`) instead of Rosewater (`#f5e0dc`) to differentiate from pointer

catppuccin/fzf#11
injust added a commit to injust/dotfiles that referenced this issue Jul 1, 2024
- Marker: Use Blue (`#89b4fa`) instead of Rosewater (`#f5e0dc`) to differentiate from pointer

catppuccin/fzf#11
injust added a commit to injust/dotfiles that referenced this issue Jul 1, 2024
- Marker: Use Blue (`#89b4fa`) instead of Rosewater (`#f5e0dc`) to differentiate from pointer

catppuccin/fzf#11
injust added a commit to injust/dotfiles that referenced this issue Jul 4, 2024
- Marker: Use Blue (`#89b4fa`) instead of Rosewater (`#f5e0dc`) to differentiate from pointer

catppuccin/fzf#11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant