Simple fix for code mirror light theme #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this, I would like refactor this change to existing _codemirror.scss. |
|
@LateNightIceCream I am unable to push commit to this PR even as a maintainer. Not sure what's going wrong. You can either give me write perms to your fork or you can make these changes yourself in this PR. My suggestions are in this gist: https://gist.github.com/griimick/85ffe6197d874d78429569b7abe0ce65 Please checkout if it seems to working fine on your end as well. Upon your commit and confirmation, I will merge the changes. |
|
It's working as expected. I updated the branch |
LateNightIceCream
added a commit
to LateNightIceCream/logseq-rose-pine
that referenced
this pull request
Sep 21, 2023
fix: unthemed code block light mode (catppuccin#14)
LateNightIceCream
added a commit
to LateNightIceCream/logseq-rose-pine
that referenced
this pull request
Sep 21, 2023
* copy codemirror dark theme css for light theme * implement refactor by griimick (catppuccin#14 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding Issue #13
Just copying the dark theme configuration in
_codemirror.scssfor the light theme (catppuccin latte).You can probably simplify the sass to remove the repetition... but it works this way!
Here is the result:
Before (default solarized look while catppuccin latte is selected as logseq theme):
After:
