Features/whiteboard #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can suggest a few changes to get this merged. You have already covered majority of it and it looks really good. I know I have been inactive lately, but I can spare time this month. Let me know if you want to continue on this. |
|
Yes, please do so :) |
|
@LateNightIceCream I was looking at an older commit before when I commented. You had already handled the parts which I was going to point out. I have made a small change, please test it out once on your end. I will merge when you give a go ahead. Thanks for working on this and for being patient :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First attempt at whiteboard theming (#12). I put some comments for the individual options and hope they are somewhat useful.
I had some issues with accidentally commiting a change to "ctp-frappe.scss" and reverting it, too. It did not change anything but I don't know how to remove the commit. I hope its nothing critical