Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add highlight overrides for mdbook-admonish #2

Closed
sgoudham opened this issue Aug 27, 2022 · 1 comment · Fixed by #59
Closed

Add highlight overrides for mdbook-admonish #2

sgoudham opened this issue Aug 27, 2022 · 1 comment · Fixed by #59
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
v0.3.0

Comments

@sgoudham
Copy link
Contributor

sgoudham commented Aug 27, 2022 •
edited

What

Highlight overrides for all types of admonishments included within mdbook-admonish should be added

Why

We want to improve the user experience when the user chooses to use other popular mdbook preprocessors, enabling good highlighting support will be more visually appealing for the user.

Acceptance Criteria

All items referenced here have good highlight overrides relevant to the catppuccin theme
@sgoudham sgoudham added enhancement New feature or request good first issue Good for newcomers labels Aug 27, 2022
@sgoudham sgoudham added this to the v0.2.0 milestone Aug 27, 2022
@NamesCode
Copy link
Member

No clue how but I can try

@nekowinston nekowinston mentioned this issue Mar 6, 2023
Merged
@sgoudham sgoudham modified the milestones: v0.2.0, v0.3.0 Jun 15, 2023
nekowinston added a commit that referenced this issue Sep 4, 2023
@nekowinston
feat: add mdbook-admonish support
a7df47a 
Closes #2
@nekowinston nekowinston mentioned this issue Sep 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging a pull request may close this issue.

feat: add mdbook-admonish support catppuccin/mdBook
2 participants
@sgoudham @NamesCode