Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration of nvim-ufo #577

Closed
testinfected opened this issue Aug 28, 2023 · 6 comments · Fixed by #575
Closed

Integration of nvim-ufo #577

testinfected opened this issue Aug 28, 2023 · 6 comments · Fixed by #575
Labels
enhancement New feature or request

Comments

@testinfected
Copy link

It would be great to add an integration to nvim-ufo

It defines the following highlight groups:

hi default UfoFoldedFg guifg=Normal.foreground
hi default UfoFoldedBg guibg=Folded.background
hi default link UfoPreviewSbar PmenuSbar
hi default link UfoPreviewThumb PmenuThumb
hi default link UfoPreviewWinBar UfoFoldedBg
hi default link UfoPreviewCursorLine Visual
hi default link UfoFoldedEllipsis Comment
hi default link UfoCursorFoldedLine CursorLine

UfoFoldedFg: Foreground for raw text of folded line.
UfoFoldedBg: Background of folded line.
UfoPreviewSbar: Scroll bar of preview window, only take effect if the border is missing right horizontal line, like border = 'none'.
UfoPreviewCursorLine: Highlight current line in preview window if it isn't the start of folded lines.
UfoPreviewWinBar: Virtual winBar of preview window.
UfoPreviewThumb: Thumb of preview window.
UfoFoldedEllipsis: Ellipsis at the end of folded line, invalid if fold_virt_text_handler is set.
UfoCursorFoldedLine: Highlight the folded line under the cursor

Any colors suggestion to make it blend with Cappuccin?

Thanks

@testinfected testinfected added the enhancement New feature or request label Aug 28, 2023
@testinfected testinfected changed the title Integration of mvim-ufo Integration of nvim-ufo Aug 28, 2023
@nullchilly
Copy link
Member

nullchilly commented Sep 1, 2023

Any color suggestions to make it blend with Cappuccin?

I personally like the default highlight groups the way it is:

image

Perhaps you want something more eye candy? Contributions are welcome in catppuccin/groups/integrations/ufo.lua

@testinfected
Copy link
Author

Hum, I do not get any highlight of folded code. Any idea?

@nullchilly
Copy link
Member

nullchilly commented Sep 4, 2023 via email

@testinfected
Copy link
Author

Transparent background, that's it.

Thanks ☺️

@emxxjnm
Copy link
Contributor

emxxjnm commented Sep 7, 2023

Hello, @nullchilly. I have a question regarding the recent modification.

When the transparent_background=true parameter is set, I expect a completely transparent setup. However, when the Folded is not respected, too many folds can ruin the entire transparent background.

Would UfoFoldedEllipsis be a better solution for @testinfected's problem?

For example:

UfoFoldedEllipsis = { bg = colors.green, fg = colors.blue }

It looks like this:
image

Users have the ability to customize the style of nvim-ufo to their liking.

@nullchilly
Copy link
Member

I hope 846388d is good enough :)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants