New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support overriding colors using vim.g.catppuccin_override_colors #165
Conversation
Nice. thanks @3rd for submitting the PR. |
Hey, @sandangel |
sorry, I'm not the owner so not really can make decision. but from an engineering perspective:
I think so. Basically we should give feedback when user configure something wrong. A warning message would be better in term of user experience.
Yes. To let user know about this feature and how to use it. So they won't open a new issue for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hi @mainrs , could you please have a review on this PR? cc @VictorTennekes @andreasgrafen @pocco81 @ayamir @asheeeshh @ShyyLexi @WitherCubes |
Hi! I am actually not familiar with |
Oh sorry. @pocco81 @vinibispo could you help? |
Sure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works perfectly
nice, can we merge the PR? |
I've been staying out of this because I'm not maintaining this whatsoever. From a technical POV I think the changes are great, but I'd prefer to have Pocco have the last word in this, as this is his baby. :D |
Sorry for the delay! I'm doing a rewrite of the plugin :) |
the `g:catppuccin_override_colors` variable was removed in favour of a setting in the user's Catppuccin conf. This commit also added the ability to change individual colors per palette and also apply changes to all of them.
from: 62856bd
|
hi @pocco81 , in that case can you fix the README? I think it's still referencing the old proposal from this PR. |
This PR proposes a simple way to override the palette colors by setting the global variable
vim.g.catppucin_override_colors
.Usage: